Change in vdsm[master]: Add deathSignal options to better peopen
shuming at linux.vnet.ibm.com
shuming at linux.vnet.ibm.com
Sat Aug 4 14:53:17 UTC 2012
Shu Ming has posted comments on this change.
Change subject: Add deathSignal options to better peopen
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/betterPopen/createprocess.c
Line 260: errno = prctl(PR_SET_PDEATHSIG, deathSignal);
errno is actually a reserved variable in C library. It should not set by the application. Usually, in linux C library, if the return value of prtcl is negative which means some errors hapen, errno can be checked to know which kind of error occurs.
Line 262: // setting the death signal
"//" is not C-native. "/*" and "*/" should be used for standard C comments.
I prefer this format:
/*
Check that parent did not already die between fork and us
setting the death signal
*/
--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
More information about the vdsm-patches
mailing list