Change in vdsm[master]: migrateStatus() progress report

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Fri Aug 3 06:31:25 UTC 2012


Mark Wu has posted comments on this change.

Change subject: migrateStatus() progress report
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/vm.py
Line 112:             self.status['progress'] = dataProcessed * 100 / dataTotal
dataProcessed represents transferred page during migration, so it could become bigger than dataTotal because qemu repeats to transfer  dirty pages.  For this reason, 
 dataProcessed * 100 / dataTotal can't show the real progress. 
I think (dataTotal - dataRemaining ) / dataTotal makes more sense.

--
To view, visit http://gerrit.ovirt.org/6824
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>


More information about the vdsm-patches mailing list