Change in vdsm[master]: BZ#844180: Change scsi scan to asynchronous

ewarszaw at redhat.com ewarszaw at redhat.com
Thu Aug 2 19:13:15 UTC 2012


Eduardo has posted comments on this change.

Change subject: BZ#844180: Change scsi scan to asynchronous
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(5 inline comments)

....................................................
File vdsm/storage/iscsi.py
Line 354:     log.warning("Performing SCSI scan, this will take up to 30 seconds")
log.debug?

Line 356:     for host in glob.glob(SCAN_PATTERN):
s/host/hba

Line 361:         log.warning("%s seconds is an illegal value for configuration option: \
Split the string in sucesive strings, '\' is unnecesary. Remove the 2nd one.

Line 366:     for i in xrange(30 - min_timeout):
Units issue: (int) - [sec] is wrong.

Line 375:         log.warning("still waiting for: %s", ps)
Add the remaining hba's (host's) identifiers to the warning.

--
To view, visit http://gerrit.ovirt.org/6796
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7665ebaed716f75af4d03ec1b6a9ff9ff5d84853
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list