Change in vdsm[master]: MOM Integration

danken at redhat.com danken at redhat.com
Wed Aug 1 20:12:14 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: MOM Integration
......................................................................


Patch Set 15: Looks good to me, but someone else must approve

(2 inline comments)

this patch has waited long enough.

....................................................
File vdsm/ksm.py
Line 109: KSM_PARAMS = {'run': 3, 'sleep_millisecs': 0x100000000,
I still do not think KSM_PARAMS should be public.

Line 114:         if k not in KSM_PARAMS.keys():
use iterkeys() when there is no reason to create a new list.

--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list