Change in vdsm[master]: Implement RLock in betterThreading

fsimonce at redhat.com fsimonce at redhat.com
Wed Aug 1 17:05:29 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Implement RLock in betterThreading
......................................................................


Patch Set 1:

> looks cool, but don't we want a test for the new object?

We do.

> are we aware of a specific usecase where our cpu is eaten by RLock.wait()?

The problem is that you can't use betterThreading.Condition() using the regular threading.RLock(): AttributeError: '_RLock' object has no attribute 'mutex'.

--
To view, visit http://gerrit.ovirt.org/6832
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I697b69fb24b4d741f37d9448295c8bb6a82464b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list