No subject


Fri Apr 27 03:18:18 UTC 2012


database *only* if skipLibvirt=True.
In that scenario, removeBridge() will be called to remove all bridge
references but
the libvirt database will be kept and next the NetInfo module
call will find the bridge into libvirt database but no reference into
the system, leading to crash.

netinfo.py:
----------------
def get():
<snip>
nets = networks()
for netname in nets.iterkeys():
        d['networks'][netname] = {}
        if nets[netname]['bridged']:
            d['networks'][netname] = { 'ports': ports(netname),
                    'stp': bridge_stp_state(netname),
                    'addr': ifaces[netname]['addr'],
                    'netmask': ifaces[netname]['netmask'],
                    'gateway': routes.get(netname, '0.0.0.0'),
                    'mtu': getMtu(netname), 'cfg': getIfaceCfg(netname)
}

On the other hand, if user just install manually the node and setup the
network vdsm-breth0 won't be created into libvirt database
automatically and skipLibvirt flag will fly correctly.

Also verified by: virsh net-list --all

To fix this report, we can call removeLibvirtNetwork() independently of
skipLibvirt and fix the order of checking if the network still exists.

Change-Id: Ie98ba38da64e34aedfd88b11880929ee4d99d0d6
Signed-off-by: Douglas Schilling Landgraf <dougsland at redhat.com>
---
M vdsm/configNetwork.py
1 file changed, 5 insertions(+), 6 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified
  Dan Kenigsberg: Looks good to me, approved
  Igor Lvovsky: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/4342
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie98ba38da64e34aedfd88b11880929ee4d99d0d6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list