Change in vdsm[master]: Fix loop device handling for mount command

danken at redhat.com danken at redhat.com
Mon Apr 30 20:58:07 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Fix loop device handling for mount command
......................................................................


Patch Set 3: (7 inline comments)

....................................................
File tests/Makefile.am
Line 27: 	hooksTests.py
missing backslash

Line 34: 	resourceManagerTests.py \
extra one

....................................................
File vdsm/storage/mount.py
Line 42: class MountError(RuntimeError):
you probably wanted to add this module to PEP8_WHITELIST

Line 50: def getRealName(path):
wouldn't you want to keep this function local?

Line 53:     except:
Edu would explode on this... Which exceptions do you expect here?

Line 62:     # backing file. As the mount command does the resolution so must we.
just a thought - maybe this fs_spec conversion SHOULD be done once on mount(), and not on iter?

Line 68:         return f.read().strip()
strip? what if the backing file name ends with a space?

--
To view, visit http://gerrit.ovirt.org/4045
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3ac6e93892ec625331dd56da0ecad6f0e39d7bc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list