Change in vdsm[master]: Add unit tests to lsblk

smizrahi at redhat.com smizrahi at redhat.com
Mon Apr 30 17:40:44 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Add unit tests to lsblk
......................................................................


Patch Set 5: I would prefer that you didn't submit this

assertEquals() already works with dictionaries

Traceback (most recent call last):
  File "/home/smizrahi/projects/vdsm/tests/ioprocessTests.py", line 484, in testDic
    self.assertEquals({1:2, 3:4}, {1:2, 3:5})
AssertionError: {1: 2, 3: 4} != {1: 2, 3: 5}
- {1: 2, 3: 4}
?           ^

+ {1: 2, 3: 5}
?           ^

--
To view, visit http://gerrit.ovirt.org/2840
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9129e90a4bcb78929810c6f069dfb5b839af01d3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list