Change in vdsm[master]: mount: use sudo only of not root user

danken at redhat.com danken at redhat.com
Mon Apr 30 15:18:23 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: mount: use sudo only of not root user
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/mount.py
Line 125:         p = misc.execCmd(cmd, sudo=isUser, sync=False)
it could have been cooler to have

 sudo=not isRoot

but this is fine, of course.

--
To view, visit http://gerrit.ovirt.org/4041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab544cc76de30ccadc320fbe673a30a630ca629f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list