Change in vdsm[master]: Unify the volume creation code in volume.create

ilvovsky at redhat.com ilvovsky at redhat.com
Mon Apr 30 12:32:32 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: Unify the volume creation code in volume.create
......................................................................


Patch Set 8: Looks good to me, but someone else must approve

(1 inline comment)

minor comment

....................................................
File vdsm/storage/volume.py
Line 385:             (srcImgUUID, "srcImgUUID", True), (srcVolUUID, "srcVolUUID", True),
hmmm, you just removed volUUID validation.
I understand why you did it, but should we validate it somewhere?

--
To view, visit http://gerrit.ovirt.org/3627
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e44da32351a420f0536505985586b24ded81a2a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list