Change in vdsm[master]: Added gluster support into vds bootstrap.

dfediuck at redhat.com dfediuck at redhat.com
Mon Apr 30 09:43:05 UTC 2012


Doron Fediuck has posted comments on this change.

Change subject: Added gluster support into vds bootstrap.
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vds_bootstrap/vds_bootstrap.py
Line 577:                 return self.rc
Let's assume you get a log file from a customer, with some issue leading into this code area.

How can you trace the actual self.rc the function ended with, and the exit point?

Hits:

1. I try to keep a single exit point.

2. Debug logging may save you hours(!) of debugging and calls to the customer...

--
To view, visit http://gerrit.ovirt.org/3351
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>


More information about the vdsm-patches mailing list