Change in vdsm[master]: Separate the Volume.share implementation

fsimonce at redhat.com fsimonce at redhat.com
Sun Apr 29 15:35:21 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Separate the Volume.share implementation
......................................................................


Patch Set 4:

The three points to clarify about this patch are:

1. Do we want to be able to specify the type of link (hard, symbolic) when we call Volume.share? (hardLink kwarg)

2. Anyway we need Volume.share to be transparent and being able to do the correct thing (overriding the link type where they don't make sense, eg: hardlinks are not supported on block domains)

3. Are the two implementation so different (eg: using oop) that we don't gain any benefit from having a common Volume.share code to be used by the inheriting classes?

--
To view, visit http://gerrit.ovirt.org/3737
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I965b56dc98fe2d6db3ef6f3d7efe2a7b9791b555
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list