Change in vdsm[master]: Fix "unknown device" issue for balloon device

ilvovsky at redhat.com ilvovsky at redhat.com
Sun Apr 29 11:54:13 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: Fix "unknown device" issue for balloon device
......................................................................


Patch Set 1: (1 inline comment)

I am not sure about changing the default behavior.
I can't see any reason to do it, in opposite it will just waste PCI slot for nothing.

....................................................
File vdsm/libvirtvm.py
Line 2206:                     dev['alias'] = alias
In generally all above is right. I used 'if address' only for case that we have more than one balloon device. In theory it can be a case, but very rare on practice.

--
To view, visit http://gerrit.ovirt.org/3901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list