Change in vdsm[master]: Implement Popen without forking back to python

smizrahi at redhat.com smizrahi at redhat.com
Sun Apr 29 09:57:04 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Implement Popen without forking back to python
......................................................................


Patch Set 1: (4 inline comments)

....................................................
Commit Message
Line 13: This is a simpler method of execing that doesn't go back to python after
I honestly don't know, I assume it's because they want to implement all the after fork logic in python to make it more portable

....................................................
File vdsm/storage/betterPopen/createprocess.c
Line 23:         return;
Yea, it's the init func template, I'm supposed to initialize custom exceptions and other init code after the condition. I left it in so if someone ever adds this s\he doesn't forget to add this condition. I'm sure the compiler will pull it out.

Line 84:     argsize = sizeof(char*) * (argn + 1);
The man page states the the last arg in the array should be null. It's logical as you don't pass the array size to the api call.

The null part is taken care of by the memset. Where I null everything just to be on the safe side.

Line 100:     if (PyList_Check(pyEnvList)) {
I thought about pulling this out but I've been too lazy, I'll move it out.

--
To view, visit http://gerrit.ovirt.org/3944
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief4ae42eb57551d7f5893bf562da451a9c98f219
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list