Change in vdsm[master]: Added gluster cli support in supervdsm.

barumuga at redhat.com barumuga at redhat.com
Sun Apr 29 06:48:32 UTC 2012


Bala.FA has posted comments on this change.

Change subject: Added gluster cli support in supervdsm.
......................................................................


Patch Set 5: (9 inline comments)

....................................................
File vdsm/constants.py.in
Line 89: EXT_GLUSTER_CLI = '@GLUSTER_CLI_PATH@'
Done

....................................................
File vdsm/gluster/gluster_cli.py
Line 31: brickCountRegEx = re.compile('(\d+) x (\d+) = (\d+)')
Done

Line 40:         out = out[1:]
Done

Line 315:     if 'PAUSED' in out[0].strip().upper():
Done

Line 322:         return 'UNKNOWN', message
Done

Line 324:         return 'NA', message
This is not an error. I haven't figured it out possible status values and soon I will get all possible values

Line 458: def _parsePeerStatus(out, gHostName, gUuid):
Done

Line 460:         out = out[1:]
Done

....................................................
File vdsm/supervdsmServer.py
Line 90:         glusterVolumeInfo = \
I will try to figure it out and do the change accordingly

--
To view, visit http://gerrit.ovirt.org/2797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>


More information about the vdsm-patches mailing list