Change in vdsm[master]: when build vdsm, run_tests.sh runs two times it take a long ...

danken at redhat.com danken at redhat.com
Thu Apr 26 10:49:42 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: when build vdsm, run_tests.sh runs two times it take a long time, remove the "make check" in vdsm.spec.in
......................................................................


Patch Set 1: I would prefer that you didn't submit this

I think that the %check section is educationally important - that's how rpms should be made.

Where is the second place `make check` is called? I see it only there when I `make rpm`.

Note again that you can skip nose tests altogether with NOSE_EXCLUDE.

--
To view, visit http://gerrit.ovirt.org/3907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list