Change in vdsm[master]: BZ#815825: Do not overwrite cacert.pem

dougsland at redhat.com dougsland at redhat.com
Thu Apr 26 03:20:41 UTC 2012


Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#815825: Do not overwrite cacert.pem
......................................................................


Patch Set 2:

> also, there is another caller to nodeCleanup: vdsm-> config -node-config. does the same problem exist 
> there?

Thinking twice: if we keep the current approach for nodeCleanup(), IMO we could call _backupCaCert() inside it  and then continue doing what this function have been doing.

> Maybe, what nodeCleanup should do is to
> unconfigure libvirt - remove vdsm's items from
> libvirt.conf (just a thought).

humm, in that case we will change the oVirt Node registration workflow. The oVirt Node calls nodeCleanup() to remove the cacert, the second step is download the new cacert from rhev-m. If we unconfigure libvirt at this time I don't think will help (from my point of view). What do you think?

--
To view, visit http://gerrit.ovirt.org/3883
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8569b5379ec8af7ad2e6dcafb2eef1fe47ab890
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>


More information about the vdsm-patches mailing list