Change in vdsm[master]: [WIP] BZ#688640 - Remove subChainSizeCalc() and getSubChain(...
ilvovsky at redhat.com
ilvovsky at redhat.com
Wed Apr 25 08:12:46 UTC 2012
Igor Lvovsky has posted comments on this change.
Change subject: [WIP] BZ#688640 - Remove subChainSizeCalc() and getSubChain(). Remove getAllChildrenList().
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File vdsm/storage/image.py
Line 1037: chainSize += vols[volUUID].getSize()
getVolumeSize ?
Line 1040: chain.insert(0, ancestor)
you can start the chain with ansestor
Line 1043: if chainSize > vols[ancestor].getSize():
s = vols[succesors].getVolumeSize()
if chainSize > s:
chainSize = s
chainSize = int(chainSize * 1.1)
Line 1056: volParams = vols[dstParentUUID].getVolumeParams()
if ansestor was son of template you didn't get it vols{}, so vols[dstParentUUID] will raise exception
--
To view, visit http://gerrit.ovirt.org/3468
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffbbf71269eddb53c032c381d10e20b771c47c6b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
More information about the vdsm-patches
mailing list