Change in vdsm[master]: BZ#815825: deployUtil Do not overwrite cacert.pem

danken at redhat.com danken at redhat.com
Tue Apr 24 19:36:52 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#815825: deployUtil Do not overwrite cacert.pem
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 11: by Engine administrator, the next reboot vdsmcert.pem  won't validate
your use of the future tense confuses me. could you detail the failing sequence?
Does it fix it, or only allow the admin to recover the old cacert somehow?

....................................................
File vdsm_reg/deployUtil.py.in
Line 1422:             dt = datetime.datetime.now()
you new code can be better encapsulated in a "backup" function.

--
To view, visit http://gerrit.ovirt.org/3883
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8569b5379ec8af7ad2e6dcafb2eef1fe47ab890
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>


More information about the vdsm-patches mailing list