Change in vdsm[master]: vm payload: add file injection to vm

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Tue Apr 24 09:41:17 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: vm payload: add file injection to vm
......................................................................


Patch Set 22: (1 inline comment)

....................................................
File vdsm/mkimage.py
Line 108:     os.remove(path)
I get the feeling this is raceful as well. Suppose path is a symlink pointing to a 'safe' location. On the other hand, then only the symlink is removed. So I'm not sure if this is actually a problem.

--
To view, visit http://gerrit.ovirt.org/2321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list