Change in vdsm[master]: Introduce API setBalloonTarget

danken at redhat.com danken at redhat.com
Mon Apr 23 20:32:34 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Introduce API setBalloonTarget
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 2118:         return {'status': doneCode, 'vmList': self.status()}
this is a new verb, I do not think 'vmList' is useful for anybody.

....................................................
File vdsm/vm.py
Line 933:         self.conf['balloon'] = self.getBalloonInfo()
this function must return immediately, and never block on a buggy qemu monitor or a busy libvirtd.

If you expect unilateral changes in balloon size, it should be polled. if not, it can be cached on other occasions.

Also, self.conf is intended for static configuration (such as VM devices, its memory size, or target balloon size) but not for volatile current balloon size.

The target balloon size should probably be part of the balloon device, not of the top-level .conf dictionary. Otherwise, it would not be acted up in migration destination host.

--
To view, visit http://gerrit.ovirt.org/3669
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36b1211dbce28bb5bb5926f2db7e2e42a698efc9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list