Change in vdsm[master]: rest-api: Add the basic server infrastructure

agl at us.ibm.com agl at us.ibm.com
Mon Apr 23 18:48:02 UTC 2012


Adam Litke has posted comments on this change.

Change subject: rest-api: Add the basic server infrastructure
......................................................................


Patch Set 3: (7 inline comments)

....................................................
Commit Message
Line 50: Signed-off-by: Adam Litke <agl at us.ibm.com>
Yes, now that I understand how the pep8 whitelist works, I will add some files and fix any problems.

....................................................
File vdsm/clientIF.py
Line 99:     def _getServerIP(self, addr=None):
Yep.  The same logic applies to multiple bindings so I want to avoid duplicating the code.

....................................................
File vdsm/rest/BindingREST.py
Line 24:     def __init__(self, cif, log, params):
I wasn't sure how many args would eventually be needed and I wanted to keep the initialization of this binding consistent with how BindingXMLRPC is done.

....................................................
File vdsm/rest/Controller.py
Line 52:         templatePath = "%s/rest/templates" % constants.P_VDSM
Ok, so pass this into the BindingREST constructor?  That is no problem at all.

....................................................
File vdsm/rest/Dispatcher.py
Line 1: import cherrypy
Done

Line 37:             # Decode any leftover %2F in the virtual_path atoms.
This part comes straight from the cherrypy default dispatcher.  My goal was to change the default dispatcher only as much as is necessary to achieve the desired behavior.

....................................................
File vdsm.spec.in
Line 45: Requires: python-cherrypy python-cheetah
Would it be good enough to allow disabling the rest bindings in vdsm.conf?

--
To view, visit http://gerrit.ovirt.org/2021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b914f7ad82fee8d9e7e3ce6847ffe4cda374a56
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list