Change in vdsm[master]: [WIP] Add the formatConverter for Storage Domain V3

fsimonce at redhat.com fsimonce at redhat.com
Mon Apr 23 17:03:48 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: [WIP] Add the formatConverter for Storage Domain V3
......................................................................


Patch Set 2: (3 inline comments)

....................................................
File vdsm/storage/imageRepository/formatConverter.py
Line 51:         vol.setrw(True)
This could be optimized (and moved somewehere else) to run just an lvm command.

Line 58:         # advertised by the metadata, FIXME: finish implementation
To fix this we need to activate the lv and read the qcow2 header while we might have a VM running on another host. It breaks the assumption that we shouldn't be reading from a volume opened in rw by qemu-kvm.

Line 120:     log.debug("Switching the cluster lock for domain %s", domain.sdUUID)
Move this at line 130 inside the future "if" condition.

--
To view, visit http://gerrit.ovirt.org/3841
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74185a4521fb88444c88de628a18c2210359af29
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list