Change in vdsm[master]: Add unit tests to lsblk

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Mon Apr 23 13:03:02 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Add unit tests to lsblk
......................................................................


Patch Set 5:

Sorry it's taken so long, but the problem was using assertDictEqual. With python 2.6 that means you must use unittest2 while nose is focused on plain unittest. Due to a lack of time I couldn't really look into it.

Turns out assertDictEqual is nothing more than a nice textual wrapper around it. I've added a compatibility function to testrunner which prefers the real assertDictEqual, but falls back to assertEqual.

--
To view, visit http://gerrit.ovirt.org/2840
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9129e90a4bcb78929810c6f069dfb5b839af01d3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list