Change in vdsm[master]: vm payload: add file injection to vm

danken at redhat.com danken at redhat.com
Mon Apr 23 11:36:17 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: vm payload: add file injection to vm
......................................................................


Patch Set 19: (2 inline comments)

....................................................
File vdsm/mkimage.py
Line 32: PAYLOAD_IMAGES_P = '/tmp'
I personally did not understand the usefulness of the /var/run->/run change, but that is besides the point for this patch.

Here, we should put everything under P_VDSM_RUN, and discuss in a different patch if we should change our default value for that constant.

Line 106:     if not path.startswith(PAYLOAD_IMAGES_P):
yep, we should use os.path.abspath() to avoid this problem.

--
To view, visit http://gerrit.ovirt.org/2321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list