Change in vdsm[master]: Uniform the block and file volume methods
ilvovsky at redhat.com
ilvovsky at redhat.com
Mon Apr 23 09:35:50 UTC 2012
Igor Lvovsky has posted comments on this change.
Change subject: Uniform the block and file volume methods
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File vdsm/storage/fileVolume.py
Line 363: return (self.getVolumePath(),)
hmmm, OK
Line 374:
Ah, OK, Fine, Good. :)
Don't be so gentle ;)
Line 446: sanlock.init_resource(sdUUID, volUUID, [(leasePath, 0)])
I don't know why you decided to remove LEASE_FILEOFFSET.
But if you decided so, the question whether we need its defintion above?
--
To view, visit http://gerrit.ovirt.org/3683
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list