Change in vdsm[master]: [WIP] Check move image conditions from SD data.

ilvovsky at redhat.com ilvovsky at redhat.com
Mon Apr 23 09:07:05 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: [WIP] Check move image conditions from SD data.
......................................................................


Patch Set 5: (6 inline comments)

....................................................
File vdsm/storage/hsm.py
Line 1290:         Determines if the image move is feasible.
legal. not feasible

Line 1294:         Move regular image not template based is always allowed
what about regular image template based ?

Line 1300:         srcVolsImgs = dict((k, v) for k, v in srcAllVols.iteritems() if imgUUID in v[0])
you promissed me to use normal variables names instead of 'k' and 'v'

Line 1314:         return True
Hmm, i have a feeling that this is only partial.
But maybe I am wrong.  Edu let's talk about this

Line 1366:             images = {}
'images'  should be out of the 'for'

Line 1372:             images[imgUUID.strip()] = misc.parseBool(pZero)
you don't need it anymore

--
To view, visit http://gerrit.ovirt.org/3466
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2422217717fe0f3cb668b4dc5f775e4a971c8d9b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list