Change in vdsm[master]: vm payload: add file injection to vm

shavivi at redhat.com shavivi at redhat.com
Sun Apr 22 11:24:36 UTC 2012


Shahar Havivi has posted comments on this change.

Change subject: vm payload: add file injection to vm
......................................................................


Patch Set 17: (3 inline comments)

....................................................
File vdsm/clientIF.py
Line 210:                             volPath = supervdsm.getProxy().mkIsoFs(files)
md5 is not good enough, other vms with the same files will get the same md5sum.
I will use some guid like the vmid

....................................................
File vdsm/supervdsmServer.py
Line 216:         mkimage.mkFloppyFs(files)
Done

Line 223:     def removeFs(self, path):
we said that it will be in /tmp/
so I will check that the path is starts with that

--
To view, visit http://gerrit.ovirt.org/2321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list