Change in vdsm[master]: vdsm/storage/misc.py: ensure uuid input is str or unicode fo...

danken at redhat.com danken at redhat.com
Sat Apr 21 14:39:23 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm/storage/misc.py: ensure uuid input is str or unicode for regex
......................................................................


Patch Set 2: Fails

I now see that testInvalidInputNotHex and testWrongLength tests fail.

You may want to add another test for the integer input, so that preferred behavior is maintained in the future.

--
To view, visit http://gerrit.ovirt.org/3687
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If16466e88a50d3af03ae7830d4d8148ebf69d0d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>


More information about the vdsm-patches mailing list