Change in vdsm[master]: Remove the unused nocache option

ilvovsky at redhat.com ilvovsky at redhat.com
Sat Apr 21 13:17:36 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: Remove the unused nocache option
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/blockVolume.py
Line 658:             self.__putMetadata(metaarr, metaid)
same comment as in fileVolume.

....................................................
File vdsm/storage/fileVolume.py
Line 398:             self.__putMetadata(metaarr, vol_path)
in former code when used default (nocache=False) in this case we performed 
self.putMetaCache(metaarr).

If you decided to get rid from metaCache it's OK but if not, you just changed behaviour.
Why?

--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list