Change in vdsm[master]: Unify the volume creation code in volume.create

fsimonce at redhat.com fsimonce at redhat.com
Fri Apr 20 15:06:58 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Unify the volume creation code in volume.create
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/storage/volume.py
Line 388:             (volUUID, "volUUID", False), (srcImgUUID, "srcImgUUID", True),
Igor, I believe that the validation we added here is going to break the volume merge, eg:

 SourceImageActionError: Error during source image manipulation: "image=07d50a04-cb2c-4ef3-a6df-78caa68d3a0a, source domain=d3d282e0-b60a-4530-9616-151f2df74897
: Invalid parameter: 'volUUID=3f865f7b-09f5-4a5d-b48e-7064a2d8f56f_MERGE'"

--
To view, visit http://gerrit.ovirt.org/3627
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e44da32351a420f0536505985586b24ded81a2a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list