Change in vdsm[master]: workaround pipe and thread issue in python

danken at redhat.com danken at redhat.com
Thu Apr 19 16:10:59 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: workaround pipe and thread issue in python
......................................................................


Patch Set 2: (6 inline comments)

note my former comment about the python bug.

....................................................
File vdsm/betterThreading.py
Line 108: ThreadPipeLock = threading.Lock()
instances begin with lower case letter,

Classes with upper case.

Line 115:         self.lockPipe = ThreadPipeLock
private data members should begin with _

Line 118:         self.lockPipe.acquire()
use "with"

Line 122: threading.Thread = vdsmThread;
please monkey-patch only pythons with this bug?

....................................................
File vdsm/storage/misc.py
Line 190: ThreadPipeLock = betterThreading.ThreadPipeLock
that's done nicer with

 from betterThreading import threadPipeLock

Line 220:     ThreadPipeLock.acquire()
better use "with". I hate to deadlock due to a silly p.stdout.write exception.

--
To view, visit http://gerrit.ovirt.org/3638
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <sming56 at gmail.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list