Change in vdsm[master]: Added VDSM interface for the virt-alignment-scan tool from l...

danken at redhat.com danken at redhat.com
Thu Apr 19 15:09:33 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Added VDSM interface for the virt-alignment-scan tool from libguestfs
......................................................................


Patch Set 11: I would prefer that you didn't submit this

(2 inline comments)

thanks again!

....................................................
File tests/alignmentScan_test.py
Line 44: 
these test..() functions are all good.

however, the output would be better-looking if you inherit from
testrunner.VdsmTestCase

currently I get the not-very-descriptive

    runTest                                                     OK
    runTest                                                     OK
    runTest                                                     OK
    runTest                                                     OK

thanks again!

Line 80:     if not virtalignscan_installed():
raising SkipTest is cooler (here and elsewhere). Currently, we may have false positives.

--
To view, visit http://gerrit.ovirt.org/2916
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d2c146a0fa3101317720f2e9c373e0d21b5cfdf
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saša Tomić <tomic80 at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Saša Tomić <tomic80 at gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list