Change in vdsm[master]: setVmTicket: add before and after hooks

danken at redhat.com danken at redhat.com
Wed Apr 18 21:29:35 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: setVmTicket: add before and after hooks
......................................................................


Patch Set 7: I would prefer that you didn't submit this

(4 inline comments)

....................................................
File vdsm/hooks.py
Line 37: def _runHooksDir(domxml, dir, vmconf={}, raiseError=True, params = {}):
no spaces around this '=' sign please.

can you think of a better name than "params"? I cannot....

Line 51:         scriptenv.update(params)
the custom params of vm  are strings, by design.
Is that what we want for these extra params, too? I am not sure. I would prefer that these params are left general, and are marshaled via json or pickle for the use of the script.

Line 135: def before_vm_set_ticket(domxml, params, vmconf={}):
all hooks have vmconf as the second arg (if they have it at all). I'd like to keep this consistency.

....................................................
File vdsm/vdsmd.8.in
Line 65: .B vmId.
the new hooks have extra environ variables, from the "params" param

--
To view, visit http://gerrit.ovirt.org/3565
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48cbc934e48055630b734a2d3c79c72b6c36f28f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list