Change in vdsm[master]: [WIP] Unify the volume creation code in volume.create

ilvovsky at redhat.com ilvovsky at redhat.com
Wed Apr 18 19:03:29 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: [WIP] Unify the volume creation code in volume.create
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(5 inline comments)

....................................................
File vdsm/storage/volume.py
Line 388:             raise se.InvalidParameterException("volUUID", volUUID)
Federico, I know that it's a former behaviour, but if you already touch this maybe we can improve both above confitions.
Actually we need to verify here UUID format for all xxxUUID parameters and I don't think that we need create volUUID by ourself.
What do you think?

Line 404:         # Stripping out all the
???

Line 421:                     volParent.share(imgPath, hard=False)
Is it mean that we will create soft link for templates on NFS?  Now we use hardlinks

Line 449:                               [sdUUID, volUUID, volPath])
Did we had this rollback for block volumes?

Line 464:             #        srcVolUUID, as they are saved in the lvm tags
saved in lvm tags only for block domains

--
To view, visit http://gerrit.ovirt.org/3627
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e44da32351a420f0536505985586b24ded81a2a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list