Change in vdsm[master]: walk around threading and pipe problem

danken at redhat.com danken at redhat.com
Wed Apr 18 11:57:41 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: walk around threading and pipe problem
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

this is scary... I am a bit reluctant to take such an intrusive patch in order to work around a supposed serious bug in Python.

Could you find a reproducer for the bug outside of Vdsm? I must require that there is a Python bug# in this commit message - otherwise we would never know when to remove this code.

....................................................
Commit Message
Line 7: walk around threading and pipe problem
as a non-English-speaker to another: the term is "workaround".

Line 9:    Calling subprocess.Popen and threading.Thread at the same time have race condition in Python 2.7.2, this patch added
shorter lines, please... they break badly on my terminal.

....................................................
File vdsm/betterThreading.py
Line 108: import storage.misc
betterThreading must not depend on the rest of vdsm.

--
To view, visit http://gerrit.ovirt.org/3638
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72e2eac7c15fd147b953eebf701257469546d62b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiawenc at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <sming56 at gmail.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list