Change in vdsm[master]: Make ClusterLock stateless

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Wed Apr 18 08:55:09 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Make ClusterLock stateless
......................................................................


Patch Set 7: (1 inline comment)

I'm not sure I like the pep8 fixes in the same patch. I think it distracts from the real fix and would prefer it in a separate patch.

....................................................
File vdsm/storage/misc.py
Line 1160:             continue
iteratePids already guarantees ints, so this try block is no longer needed.

--
To view, visit http://gerrit.ovirt.org/3497
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50f5fa79220bc9c0c5e35187415c7ff26c6dd28
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list