Change in vdsm[master]: improve add/del bridgesless network
dougsland at redhat.com
dougsland at redhat.com
Wed Apr 18 04:41:32 UTC 2012
Douglas Schilling Landgraf has posted comments on this change.
Change subject: improve add/del bridgesless network
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File vdsm/configNetwork.py
Line 323: self._removeFile(self.NET_CONF_PREF + bridge)
Indeed, it's a mistake from the middle of the night ;-) Anyway, I will provide a improved patch.
Line 737: subprocess.call([constants.EXT_BRCTL, 'delbr', network])
I can move there, but if I understood correctly it's "configWriter", it's about managing config files only.
....................................................
File vdsm/netinfo.py
Line 99: mtu = "0"
if the bridge doesn't exist, I don't think it's correct to setup mtu to 1500 as default value.
--
To view, visit http://gerrit.ovirt.org/3615
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f170eaced2d6f756b84cb52e9efce6dc9722405
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
More information about the vdsm-patches
mailing list