Change in vdsm[master]: Orthogonal storage repository conversion

abaron at redhat.com abaron at redhat.com
Tue Apr 17 14:02:10 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: Orthogonal storage repository conversion
......................................................................


Patch Set 15: I would prefer that you didn't submit this

(5 inline comments)

-1 because of:
vdsm/storage/imageRepository/formatConverter.py
Line 30:	

s/CONVERION/CONVERSION/

The rest is nit pick.

....................................................
Commit Message
Line 10: not correct as ion the future we will allow conversion from one domain
s/ion/in/
s/will/may/

Line 19: different objects there needs to bee a 3rd party to convert to\from
s/bee/be/

Line 22: This also seperates the conversion process from the domain logic
s/seperates/separates/

....................................................
File Makefile.am
Line 41:                  vdsm/storage/misc.py \
Don't we keep such file lists sorted everywhere else?

....................................................
File vdsm/storage/imageRepository/formatConverter.py
Line 30: _IMAGE_REPOSITORY_CONVERION_TABLE = {
s/CONVERION/CONVERSION/

--
To view, visit http://gerrit.ovirt.org/3045
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f43faaa9578ddafbae8e3aa01c02b1d42b177ab
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list