Change in vdsm[master]: Added getDevicePartedInfo function in supervdsm.
barumuga at redhat.com
barumuga at redhat.com
Tue Apr 17 09:05:00 UTC 2012
Bala.FA has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Patch Set 4: (7 inline comments)
New patch is on the way with these changes
....................................................
File tests/parted_utils_tests.py
Line 45: os.close(tempFd)
according to python docs, mktemp: Deprecated since version 2.3: Use mkstemp() instead.
Line 49: rc, out, err = utils.execCmd(cmd.split())
Done
Line 52: rc, out, err = utils.execCmd(cmd.split(), sudo=True)
Done. I will use @ValidateRunningAsRoot
Line 52: rc, out, err = utils.execCmd(cmd.split(), sudo=True)
This test should run as root. Sorry for the confusion.
Line 69: assert not putils.getDevicePartedInfo('/dev/abcdef')
Done
Line 72: info = putils.getDevicePartedInfo(self.devPath)
Required root privilege (not sudo) to run the test.
Line 95: assert (info['type'] == 'gpt')
Done
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
More information about the vdsm-patches
mailing list