Change in vdsm[master]: Make API.py conform to pep8

smizrahi at redhat.com smizrahi at redhat.com
Mon Apr 16 20:56:27 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Make API.py conform to pep8
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(4 inline comments)

I only commented on errors once or twice but they are spread throughout

....................................................
File vdsm/API.py
Line 233:                                           % vmParams['vmId'])
http://www.python.org/dev/peps/pep-0008/#id14
"The preferred place to break around a binary operator is after the operator, not before it."

Line 244:                             % (vmParams['vmId'], len(self._cif.vmContainer)))
again

Line 372:                                            vmId, nic'}}
I think you meant
.... parameters: ' + \
'vmId...

Line 388:                                            vmId, nic'}}
again

--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sheldon Feng <shaohef at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list