Change in vdsm[master]: pylint: vdsm/libvirtvm.py

ilvovsky at redhat.com ilvovsky at redhat.com
Mon Apr 16 12:42:38 UTC 2012


Igor Lvovsky has submitted this change and it was merged.

Change subject: pylint: vdsm/libvirtvm.py
......................................................................


pylint: vdsm/libvirtvm.py

E:914,11:NetworkInterfaceDevice.__init__: Access to member 'nicModel' before its definition line 915

Modify the kwarg dict before device init.

Change-Id: I2b090c647089588f621552f7b99aed4ba33c0e71
Signed-off-by: Ryan Harper <ryanh at us.ibm.com>
---
M vdsm/libvirtvm.py
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Saggi Mizrahi: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, but someone else must approve
  Igor Lvovsky: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/3443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b090c647089588f621552f7b99aed4ba33c0e71
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list