Change in vdsm[master]: setVmTicket: add before and after hooks

abaron at redhat.com abaron at redhat.com
Mon Apr 16 12:11:26 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: setVmTicket: add before and after hooks
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

Just a few minor comments.

....................................................
Commit Message
Line 10: the benefit of the hook scripts.
Like the rest of the hooks, setVmTicket should get a custom properties dict and not 'user-name' and 'user-id'.
engine would always send user-name and user-id and the custom properties users have defined there to allow for normal hooks behaviour.

....................................................
File vdsm/API.py
Line 502:     def setTicket(self, password, ttl, userName, userId, existingConnAction):
As I mentioned on the commit message, should be custom properties the same as the rest of the hooks (I don't remember the name of the dictionary, but should be persistent)

....................................................
File vdsm.spec.in
Line 554: %dir %{_libexecdir}/%{vdsm_name}/hooks/before_set_ticket
please rename to include 'vm' as the rest of the hooks are named.
i.e. before_vm_set_ticket and after_vm_set_ticket

--
To view, visit http://gerrit.ovirt.org/3565
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48cbc934e48055630b734a2d3c79c72b6c36f28f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list