Change in vdsm[master]: Use domain proxies instead of actual domain references

abaron at redhat.com abaron at redhat.com
Mon Apr 16 07:44:54 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: Use domain proxies instead of actual domain references
......................................................................


Patch Set 13: I would prefer that you didn't submit this

(3 inline comments)

Apparently I didn't publish my comments (reviewed this in revision 11).  always annoying!
Anyway, sorry for the belated review.

....................................................
File vdsm/storage/sdc.py
Line 48:         return getattr(dom, attrName)
this causes a "produce" every time we access any property of the domain, this appears like serious overhead to me.

Line 51:         return self._cache._realProduce(self._sdUUID)
calling a private method of a different object is not nice.

Line 104:             dom = DomainProxy(self, sdUUID)
DomainProxy is supposed to get 3 params but you're passing only 2? "def __init__(self, cache, sdUUID):" I'm not sure how this worked for you, what am I missing?

--
To view, visit http://gerrit.ovirt.org/3044
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list