Change in vdsm[master]: Make outOfProcess.py confrom to pep8

danken at redhat.com danken at redhat.com
Sun Apr 15 13:42:40 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Make outOfProcess.py confrom to pep8
......................................................................


Patch Set 1: No score

(1 inline comment)

....................................................
File vdsm/storage/outOfProcess.py
Line 121:         attr = _ModuleWrapper(mod_os.path, self._processPool)
but "attr" is such a vague and general name. it is an attr for self.os, but _ModuleWrapper(bla) is a mod wrapper for the remote "os".

--
To view, visit http://gerrit.ovirt.org/3489
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7dd69ab1fc34d86fcfec45f0780d2efcec1fdde8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list