Change in vdsm[master]: Add betterThreadingTests

abaron at redhat.com abaron at redhat.com
Thu Apr 12 20:15:36 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: Add betterThreadingTests
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File tests/betterThreadingTests.py
Line 76:             sleep(2)
can't we make the times shorter? every sleep we add in tests adds time to wait when running the test suite
It would be even better if we could avoid sleep altogether...

Line 147:     def testWait1L(self):
when running the suite it would be easier on the eye to have more descriptive names.  No one would know that testWait1L means test wait condition for 1s with lock

Line 167:             sleep(2)
maybe pass the function to run as parameter so that only the "NotPass" test would have a sleep and then too a shorter one if possible

--
To view, visit http://gerrit.ovirt.org/3495
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63e1892937ae20fd2577d49faf69a617b4a17c04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>


More information about the vdsm-patches mailing list