Change in vdsm[master]: [WIP] Don't waste SD produces in validateSdUUID.

ilvovsky at redhat.com ilvovsky at redhat.com
Thu Apr 12 09:15:43 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: [WIP] Don't waste SD produces in validateSdUUID.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

You did it well, just finish the job if started it :)

....................................................
File vdsm/storage/hsm.py
Line 1304:         if not sdCache.produce(dstDomUUID).isBackup():
what about this one?

Line 1337:         if not sdCache.produce(dstDomUUID).isBackup():
and this one

Line 2216:         dom = sdCache.produce(sdUUID=sdUUID)
same here

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list