Change in vdsm[master]: Added getMdUuidMap function in supervdsm.

danken at redhat.com danken at redhat.com
Thu Apr 12 08:32:52 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Added getMdUuidMap function in supervdsm.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

beside the interface issue, I would like to ask for a unit test, and adding the new file to pep8's whitelist.

....................................................
File vdsm/md_utils.py
Line 30: def getMdUuidMap():
I would very much appreciate a better name/doc/higher-level-interface. Which are the keys and the values of this map?

--
To view, visit http://gerrit.ovirt.org/3469
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>


More information about the vdsm-patches mailing list