Change in vdsm[master]: Fix pylint error in BindingXMLPRC

Ryan Harper ryanh at us.ibm.com
Tue Apr 10 20:30:38 UTC 2012


Ryan Harper has posted comments on this change.

Change subject: Fix pylint error in BindingXMLPRC
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/BindingXMLRPC.py
Line 848:                 logLevel = logging.CRITICAL
You're right about the value; Not clear if there is any string value lower than logging.DEBUG (which is 10).  It seems that .CRITICAL means it's critical that the user see this versus being less important (lower value).

I should have done a global s/TRACE/XXXX; I was just working through the pylint output one file at a time.  I'll rework that once we decide what the right value.

I don't think there is anything EVIL about logging.TRACE, only that the name isn't supported in python any more.

[root at f16-node ~]# cat /etc/issue
Fedora release 16 (Verne)
Kernel \r on an \m (\l)

[root at f16-node ~]# python
Python 2.7.2 (default, Oct 27 2011, 01:40:22) 
[GCC 4.6.1 20111003 (Red Hat 4.6.1-10)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import logging
>>> logging.TRACE
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'module' object has no attribute 'TRACE'

--
To view, visit http://gerrit.ovirt.org/3437
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I957bc2b6aff62ac0e450a8e712384acf0e7adbd8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>


More information about the vdsm-patches mailing list