Change in vdsm[master]: fix masterVersion 0 err when connecting storage pool

smizrahi at redhat.com smizrahi at redhat.com
Tue Apr 10 01:35:22 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: fix masterVersion 0 err when connecting storage pool
......................................................................


Patch Set 3: Do not submit

(4 inline comments)

None of these can be None as they are recieved from XML RPC which doesn't support passing None (at least not in the way we use it).

I don't understand the problem this is trying to solve

....................................................
File vdsm_cli/vdsClient.py
Line 815:             master_ver = None
Are you sure you can send None over xmlrpc?

....................................................
File vdsm/storage/hsm.py
Line 825:         if masterVersion is not None:#None just for connected pool,masterVersion >= 0 for not connected one
Comments in the same line as the code are frowned upon.
Also try and keep width below 80 chars

Line 835:                 if msdUUID is None or masterVersion is None:
msdUUID can be an empty string

Line 859:             if not scsiKey:
Scsi key is ignored, no need to make sure it was entered

--
To view, visit http://gerrit.ovirt.org/2679
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7228bd340a4281400e16c26b311d9945dd5ce597
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sheldon Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list